Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mapbox-gl to v1.3.2 #4230

Merged
merged 4 commits into from
Sep 30, 2019
Merged

Bump mapbox-gl to v1.3.2 #4230

merged 4 commits into from
Sep 30, 2019

Conversation

@etpinard etpinard added this to the v1.50.0 milestone Sep 27, 2019
@etpinard etpinard changed the title Bump mapbox-gl Bump mapbox-gl to v1.3.2 Sep 27, 2019
@etpinard
Copy link
Contributor Author

etpinard commented Sep 27, 2019

Note that mapbox-gl now allows users to set their access tokens per map as opposed to during module instantiation (in mapbox/mapbox-gl-js#8364).

This means that we could implement a way to plot multiple mapbox subplots with different mapbox access token on the same plotly.js graph.

//
// Need a 10ms delay (0ms should suffice to skip a thread in the
// render loop) to workaround mapbox-gl bug introduced in v1.3.0
setTimeout(resolve, 10);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archmoj w/o this extra 10ms delay, call sequences like

// off the `mapbox_0` mock
Plotly.restyle(gd, 'visible', false)
.then(() => Plotly.restyle(gd, 'visible', true))
.then(() => Plotly.restyle(gd, 'visible', 'legendonly', [1]))

fails and logs

image


I suspect this is caused by mapbox/mapbox-gl-js#8633 - but I haven't investigated further.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll leave this conversation open so that it is noticed by in the QA.

@etpinard
Copy link
Contributor Author

Looks like we'll also need 422d5d3 to make test-image pass on this branch - cc #4227 (comment)


Let's wait a little bit before. Ideally, I would merge master into this branch after #4219 gets merged.

@archmoj
Copy link
Contributor

archmoj commented Sep 28, 2019

@etpinard thanks very much for the PR.
💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants