Fix line.width attr declaration in *contour traces
#4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- unset dflt in contour `line.width`, explain default logic in description - reuse contour `line` declaration in contourcarpet - set hard dflt in histogram2dcontour `line.width` declaration, as histogram2dcontour trace only support level-style contours at the moment.
etpinard
commented
Sep 25, 2019
| 'Sets the contour line width in (in px)', | ||
| 'Defaults to *0.5* when `contours.type` is *levels*.', | ||
| 'Defaults to *2* when `contour.type` is *constraint*.' | ||
| ].join(' ') |
There was a problem hiding this comment.
Here's the corresponding default logic:
reused by contourcarpet and histogram2dcontour
reused by contourcarpet
|
@etpinard Nicely done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4203
line.width, explain default logic in descriptionlinedeclaration in contourcarpetline.widthdeclaration,as histogram2dcontour trace only support level-style contours
at the moment.
cc @archmoj