Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More auto-margin fixes (some of them temporary) #4216

Merged
merged 5 commits into from
Sep 25, 2019
Merged

More auto-margin fixes (some of them temporary) #4216

merged 5 commits into from
Sep 25, 2019

Commits on Sep 24, 2019

  1. use (xl,xr,yt,yb) instead of (x,y) as push margin coordinates 

    ... this enables an axis to push the margin on
    both side of its span
    @etpinard
    etpinard committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    f506306 View commit details
    Browse the repository at this point in the history

  2. do not try to re-fix axis label overlaps when current autoangle:=90 

     N.B. during auto-margin redraw, if the axis fixed its label overlaps
 by rotating 90 degrees, do not attempt to re-fix its label overlaps
 as this can lead to infinite redraw loops!

 Moreover, use ax._prevTickAngles for retrieve "lastAngle".
 Previous ax._tickAngles was used, but this one gets clear early
 Axes.drawOne, so it didn't really do anything.
    @etpinard
    etpinard committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    7a8eedf View commit details
    Browse the repository at this point in the history

  3. Add (large) upper bound on the number of redraw calls 

    ... that Plots.doAutoMargin can trigger.
    @etpinard
    etpinard committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    631014a View commit details
    Browse the repository at this point in the history

  4. add mock 🔒 case that currently result in infinite loop

    @etpinard
    etpinard committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    58fd632 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. add extra ax.automargin condition for fixLabelOverlaps bypass

    @etpinard
    etpinard committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    9a665db View commit details
    Browse the repository at this point in the history