Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scattergl hover over nulls #4213

Merged
merged 2 commits into from
Sep 23, 2019
Merged

Fix scattergl hover over nulls #4213

merged 2 commits into from
Sep 23, 2019

Commits on Sep 23, 2019

  1. fix #4212 - create new pointData object instead extending original 

    ... so that we don't mutate pointData.cd and propagate 'fake'
    `gd.calcdata[i][j]` to subsequent _module.hoverPoints calls.
    @etpinard
    etpinard committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    880b7e9 View commit details
    Browse the repository at this point in the history

  2. 🔪 obsolete if-else clause 

    - post #3578 all scattergl traces either set a `tree` or
  and `ids` array during the calc step.
    @etpinard
    etpinard committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    5d9bd0a View commit details
    Browse the repository at this point in the history