Fix toggleHover and resetViews modebar buttons for some partial bundle + graph setups #4184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4164 - by adding fallbacks to
fullLayout._subplots[k]
entries in modebar buttons handlers called on graphs with different subplot arrangements that may or may not be part of one's partial or custom bundle.The reason why some
fullLayout._subplots[k]
are empty in partial bundles is due to this routine here:plotly.js/src/plots/plots.js
Lines 584 to 624 in 9b5f089
which loops over the registered base-plot modules - which is a subset of all the available base-plot modules.
cc @plotly/plotly_js - we don't publish partial bundles on CI, so I can't show you a before/after from #4164 (comment) - I hope you'll find the fix trivial enough to not mind. Please let me know if that's not case.