Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not show prefix and suffix for minor log axes #4064

Merged
merged 3 commits into from
Jul 22, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 20, 2019

Hopefully fixes #3250 & friends (i.e. #3689).

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jul 20, 2019
@etpinard
Copy link
Contributor

Thanks very much for taking this on @archmoj !

I'm curious, you wrote that this PR fixes #3250 & friends, which friend issues are you referring to exactly?

@archmoj
Copy link
Contributor Author

archmoj commented Jul 22, 2019

Thanks very much for taking this on @archmoj !

I'm curious, you wrote that this PR fixes #3250 & friends, which friend issues are you referring to exactly?

@etpinard
This one: #3689.

@etpinard
Copy link
Contributor

This fix is looking good to me 💃

Nice work @archmoj !

@etpinard etpinard added this to the v1.49.0 milestone Jul 22, 2019
@archmoj archmoj merged commit 1400437 into master Jul 22, 2019
@archmoj archmoj deleted the minor-log-axes-no-suffix-prefix branch July 22, 2019 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tickprefix/suffix on log axes single-digit labels?
2 participants