Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boxplot with categoryorder #3983

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Fix boxplot with categoryorder #3983

merged 2 commits into from
Jun 25, 2019

Conversation

antoinerg
Copy link
Contributor

Closes #3970

This seems a bit hacky to me to it does fix the issue at hand.

@antoinerg
Copy link
Contributor Author

@etpinard
Copy link
Contributor

Thanks for the fix. Nicely done!

While at it, it would be nice to investigate if the other "per-graph" variables initialised in Plots.doCalcdata:

plotly.js/src/plots/plots.js

Lines 2755 to 2764 in 795220f

fullLayout._violinScaleGroupStats = {};
// for calculating avg luminosity of heatmaps
gd._hmpixcount = 0;
gd._hmlumcount = 0;
// for sharing colors across pies / sunbursts / funnelarea (and for legend)
fullLayout._piecolormap = {};
fullLayout._sunburstcolormap = {};
fullLayout._funnelareacolormap = {};

lead to similar bugs when sorting categories per value.


Regardless this is a great fix, so 💃

@etpinard etpinard added status: reviewable bug something broken labels Jun 25, 2019
@antoinerg antoinerg merged commit 2885f23 into master Jun 25, 2019
@etpinard etpinard deleted the fix-box-categoryorder branch June 27, 2019 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some categoryorder creates invisible extra series for boxplot
2 participants