Always include the very first and last points for fills #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... during the line-decimation algo
etpinard
commented
Mar 29, 2019
| @@ -0,0 +1,21 @@ | |||
| { | |||
| "data": [ | |||
There was a problem hiding this comment.
which looks like:
on master.
|
Thanks for the fix @etpinard ! 💃 |
src/traces/scatter/line_points.js
Outdated
| @@ -387,7 +391,9 @@ module.exports = function linePoints(d, opts) { | |||
|
|
|||
| clusterRefDist = ptDist(clusterHighPt, clusterStartPt); | |||
|
|
|||
| if(clusterRefDist < getTolerance(clusterHighPt, nextPt) * minTolerance) continue; | |||
| // #3147 - always include the very first and last points for fills | |||
| if(!(fill && (pti === 0 || len - pti === 1)) && | |||
There was a problem hiding this comment.
I've never seen pti === len - 1 written quite that way 🤔
There was a problem hiding this comment.
yeah, that was weird, fixed in 9e8c3e9
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... during the line-decimation algo - fixes #3147
cc @plotly/plotly_js