-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement connectGaps #361
Conversation
78a0a85
to
a4c4e0d
Compare
Sorry for the messy commit history. I merged in the middle which screwed up the rebase. |
Ref commit in |
plots['tet'] = require('@mocks/gl3d_tet.json'); | ||
plots['surface_intensity'] = require('@mocks/gl3d_surface_intensity.json'); | ||
plots['connectgaps'] = require('@mocks/gl3d_scatter3d-connectgaps.json'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this line should be:
plots['scatter3d-connectgaps'] = require('@mocks/gl3d_scatter3d-connectgaps.json');
so that the corresponding image baseline is displayed properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops! that screwed up when I rebased
@mikolalysenko Looking good. Thanks for doing this 🍻 We'll merge this in as soon as the minor edits ⏫ are done. |
nicely done. |
This PR solves #281
For example, the following data:
Would produce the following plot:
Gaps in line plots are implemented by inserting a pair of degenerate triangles into the triangle strip