Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic alignment of ticks in 3D scenes #3131

Merged
merged 6 commits into from
Oct 23, 2018
Merged

Automatic alignment of ticks in 3D scenes #3131

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
717f2ea
align ticks to identical direction on the axis
archmoj Oct 20, 2018
dd614cf
baseline images updated - note the ticks are now aligned to one axis …
archmoj Oct 20, 2018
420abd3
optimized code (rewrites without if statements) - kept two tick align…
archmoj Oct 20, 2018
743925b
fix for PHX issue 140 and use upwards ranges as default behaviour
archmoj Oct 22, 2018
6a4f3c2
updated baseline images
archmoj Oct 22, 2018
4fc0c40
using new version of gl-plot3d module
archmoj Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
"gl-mat4": "^1.2.0",
"gl-mesh3d": "^2.0.0",
"gl-plot2d": "^1.3.1",
"gl-plot3d": "^1.5.7",
"gl-plot3d": "git://github.com/gl-vis/gl-plot3d.git#ecb766038c6c3bb041a6405795c42512c56f5387",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually pointing to this change on gl-axes3d:
gl-vis/gl-axes3d@master...align-ticks

"gl-pointcloud2d": "^1.0.1",
"gl-scatter3d": "^1.0.11",
"gl-select-box": "^1.0.2",
Expand Down