Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make legend scrollbar valid svg elements #304

Merged
merged 1 commit into from
Mar 1, 2016
Merged

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Mar 1, 2016

@mdtusz

Fixes a bug introduced in #243 and discovered on plot.ly pdf and eps image exports.

To be a valid all must have set width and height attributes. From https://validator.w3.org:

image

- to be a valid <svg> all <rect> must have set width
  and height attributes.
@mdtusz
Copy link
Contributor

mdtusz commented Mar 1, 2016

💃 once tests are 👍

etpinard added a commit that referenced this pull request Mar 1, 2016
Make legend scrollbar valid svg elements
@etpinard etpinard merged commit 0456633 into master Mar 1, 2016
@etpinard etpinard deleted the fix-pdf-export branch March 1, 2016 20:48
@etpinard etpinard mentioned this pull request Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants