-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abbreviation for yellow in colorscale names is 'Yl' not 'YI' [fixes #269] #295
Conversation
- add backward compatible clean data step - add cleanData tests
@@ -750,6 +751,17 @@ function cleanData(data, existingData) { | |||
} | |||
} | |||
|
|||
// fix typo in colorscale definition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe put the check for YIGnBu
/YIOrBu
in a attribute coercion step instead of in logic code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want YIGnBu and YIOrBu to be considered valid colorscale names, we just want to clean up an old typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... unless we want to consider YIGnBu
an alias for YlGnBu
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, just seems hacky to have it being handled in plot_api.js
instead of in the colorscale
component - if something uses colorscale but doesn't flow through this codepath, it won't get the same treatment, whereas I'd assume that there's a common entry for colorscale related things in colorscale/____.js
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanData
is pretty up-front about its purpose.
Okey dokes. 💃 |
👍 |
- to reflect spaceless color strings in colorscale definitions.
Abbreviation for yellow in colorscale names is 'Yl' not 'YI' [fixes #269]
@mdtusz @alexcjohnson
easy.