Abbreviation for yellow in colorscale names is 'Yl' not 'YI' [fixes #269] #295
Conversation
- add backward compatible clean data step - add cleanData tests
etpinard
changed the title
| @@ -750,6 +751,17 @@ function cleanData(data, existingData) { | |||
| } | |||
| } | |||
|
|
|||
| // fix typo in colorscale definition | |||
There was a problem hiding this comment.
Should we maybe put the check for YIGnBu/YIOrBu in a attribute coercion step instead of in logic code?
There was a problem hiding this comment.
we don't want YIGnBu and YIOrBu to be considered valid colorscale names, we just want to clean up an old typo.
There was a problem hiding this comment.
... unless we want to consider YIGnBu an alias for YlGnBu.
There was a problem hiding this comment.
Agreed, just seems hacky to have it being handled in plot_api.js instead of in the colorscale component - if something uses colorscale but doesn't flow through this codepath, it won't get the same treatment, whereas I'd assume that there's a common entry for colorscale related things in colorscale/____.js.
There was a problem hiding this comment.
cleanData is pretty up-front about its purpose.
|
Okey dokes. 💃 |
|
👍 |
- to reflect spaceless color strings in colorscale definitions.
Abbreviation for yellow in colorscale names is 'Yl' not 'YI' [fixes #269]
@mdtusz @alexcjohnson
easy.