Replot when webgl buffer dims don't match canvas dims #2939
Conversation
- this can happen when relayouting to large width/height on some browsers (e.g. Chrome 68)
src/plot_api/plot_api.js
Outdated
| 'due to browser/WebGL bug.', | ||
| 'Clearing graph and plotting again.' | ||
| ].join(' ')); | ||
| exports.newPlot(gd, gd.data, gd.layout); |
There was a problem hiding this comment.
Hmm. This may not be the best idea actually. If the canvas and gl buffer dimensions still don't match after the replot, we could have an infinite loop.
There was a problem hiding this comment.
I'm not sure how that would happen, but if you're worried about it we could do something to limit to 1 redraw like
if(!gd._reglRedrawing) {
gd._reglRedrawing = true;
return exports.newPlot(...).then(function() { gd._reglRedrawing = false; });
}
There was a problem hiding this comment.
That's essentially when I went for in 85a646f
|
New attempt in -> 6fcec6e Note that, we need to call |
src/plot_api/plot_api.js
Outdated
| fullLayout = gd._fullLayout; | ||
| Plots.doCalcdata(gd); | ||
| fullLayout._redrawFromWrongGlDimensions = 1; | ||
| return drawFramework(); |
There was a problem hiding this comment.
Nice! Still a substantial win as we don't need to redo all the drawing.
So, there's still recursion here - but it's just back into this function. So instead of a _redrawFromWrongGlDimensions flag on _fullLayout (that we'd probably have to handle more carefully in principle due to relinkPrivateKeys) could we use a local var in the outer scope?
There was a problem hiding this comment.
Ok, done in 3879a41
There was a problem hiding this comment.
one less private key to worry about when we'll 🔪 relinkPrivateKeys.
... to avoid infinite drawFramework loops
|
Thanks for tracking this down and bearing with my iterative comments :) Looks great now. 💃 |
... as this can unfortunately happen when relayouting to large width/height on some browsers e.g. Chrome 68 and Chrome 64 (that we use on CI).
Note that this doesn't just affect sploms, but all regl-based trace type and presumably all WebGL-trace types.
cc @alexcjohnson