-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-axis-type sploms #2899
Merged
Merged
Multi-axis-type sploms #2899
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
dd563bb
consider only splom dimensions on axis during axis autotype
etpinard 9e1869d
copy back axes categories on axes that skipped makeCalcdata,
etpinard 9da5a1b
add splom mutli axis type mock
etpinard f3c73db
swap (x|y)a -> (x|y)id for clarity
etpinard b3d27bd
skip dims with conflicting axis types
etpinard 9039a8e
keep track of visible dimensions using visibleDims list
etpinard ab7d9c6
bring handleTypeDefaults api on-par
etpinard 39b71bb
add dimensions[i].axis.type
etpinard 57ddadb
pass gd to basePlotModule.updateFx
etpinard 15efc72
clear additional 'matrixTrace' use by regl-splom for selection
etpinard 1823904
log info when skipping splom dim of conflicting axis types
etpinard 390f292
add mock of splom with conflicting axis types
etpinard adb0004
use 'j' in value loop
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| { | ||
| "data": [ | ||
| { | ||
| "type": "splom", | ||
| "opacity": 0.9, | ||
| "showupperhalf": false, | ||
| "diagonal": {"visible": false }, | ||
| "dimensions": [ | ||
| { | ||
| "label": "numeric", | ||
| "values": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10] | ||
| }, | ||
| { | ||
| "label": "decimal", | ||
| "values": [-3.3, 2.2, -1.1, 0, 1.1, -2.2, 3.3, 4.4, -5, 6] | ||
| }, | ||
| { | ||
| "label": "bool", | ||
| "values": [false, true, true, true, false, true, false, false, false, true] | ||
| }, | ||
| { | ||
| "label": "0/1", | ||
| "values": [0, 1, 1, 1, 1, 1, 0, 0, 0, 0] | ||
| }, | ||
| { | ||
| "label": "string", | ||
| "values": ["lyndon", "richard", "gerald", "jimmy", "ronald", "george", "bill", "georgeW", "barack", "donald"] | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "layout": { | ||
| "hovermode": "closest", | ||
| "margin": { | ||
| "b": 80, | ||
| "l": 80, | ||
| "r": 30, | ||
| "t": 30 | ||
| }, | ||
| "yaxis2": {"type": "category"}, | ||
| "yaxis3": {"type": "category"}, | ||
| "xaxis3": {"type": "category"}, | ||
| "xaxis4": {"type": "category"} | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This here might be tricky to find for users as e.g. nothing indicates that
yaxis2corresponds to the boolean data array.Perhaps we could include this in the trace
dimensions[i]containers?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great idea -
dimension.type = 'category'to override the autotype for both axes. That would certainly reduce (though not eliminate) the chance of mismatches like #2899 (comment)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with
dimensions[i].axis.typein 39b71bbI'm thinking the extra container might make it cleaner if we add more "splom-generated-axis" settings e.g. I suspect some users would want to set
dimensions[i].axis.showgrid: falseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha exactly my rationale in #2899 (comment) - I should read all your comments before making my own. Anyway, love it.