Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend item for 'legendonly' traces with array 'marker.symbol' #2816

Merged
merged 3 commits into from
Jul 16, 2018

Conversation

etpinard
Copy link
Contributor

fixes #2672

Ending the week with -- guess what -- another bug fix cc @alexcjohnson

@etpinard etpinard added bug something broken status: reviewable labels Jul 13, 2018
"yaxis": "y2",
"marker": {
"size": 15,
"symbol": ["square", "square", "square", "square", "square", "square", "square", "square", "square"]
Copy link
Contributor Author

@etpinard etpinard Jul 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The legend item here currently renders as a circle (using the Drawing.singlePointStyle fallback).

@alexcjohnson
Copy link
Collaborator

💃 Capping off a pretty great week!

@etpinard etpinard merged commit f9e90c4 into master Jul 16, 2018
@etpinard etpinard deleted the legendonly-arrayok-marker-symbol branch July 16, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend symbol changed to default when trace is disabled in legend
2 participants