Better axis range animations #2788
Conversation
... by skipping Cartesian.plot step when no trace data need to
be transitioned.
... and other traces that require a _module.setPositions call
|
|
||
| var calls = Registry.call.calls.all(); | ||
| expect(calls.length).toBe(1, 'just one Registry.call call'); | ||
| expect(calls[0].args[0]).toBe('relayout', 'called Registry.call with'); |
There was a problem hiding this comment.
This is a pretty low-level assertion, not clear to me that it would catch breaks other than the exact change you made here. Would it be possible to do something like:
var animatePromise = Plotly.animate(...)
expect(stuff).toBe(nearWhereItStarted)
return animatePromise;
})
.then(function() {
expect(stuff).toBe(nearWhereItFinishes);
expect(theFullDataAndRegistryCallStuff);ie something about the scatter marker and bar positions being updated async that would have failed before this change?
There was a problem hiding this comment.
ie something about the scatter marker and bar positions being updated async that would have failed before this change?
The marker and bar position does not change, it's the subplot and clip rect translate transforms that change during axis range transitions via Cartesian.transitionAxes (which mimics cartesian dragbox logic).
Better test added in -> 19300f9
|
Awesome find, that we get a whole new class of animations with this little change!!! 🎉 🏆 |
|
💃 |
Axis range animations like https://codepen.io/plotly/pen/GjkZNk (which is featured on https://plot.ly/javascript/animations/) are broken on master ever since #2579 (the cartesian d3-iomatic push, again):
This PR makes that example run smoothly again:
but what's more exciting, this fix -- along with commit c708190 -- allows us to smoothly animate axis ranges on cartesian subplots with traces other than
scatter. For example a bar chart: