Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scatter3d scalar hovertext handling #2698

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Jun 5, 2018

Easy fix cc @alexcjohnson

But: wow, I wish hover from subplot type to another other would be done in a DRYer way 😫

@etpinard etpinard added bug something broken status: reviewable labels Jun 5, 2018
@alexcjohnson
Copy link
Collaborator

yep, at some point we should make an attempt to 🌴 it up - will probably uncover and fix a bunch more bugs that way like I did (am doing...) with colorbars in #2681

But nice quick fix 💃

@etpinard
Copy link
Contributor Author

etpinard commented Jun 6, 2018

we should make an attempt to it up

To me, the first step to 🌴 ing this up would be to make all hover-related routines use just _fullData (i.e. no calcdata) so that e.g. scattergl and scatter can share the same hoverPoints method.

@etpinard etpinard merged commit 8690ee7 into master Jun 6, 2018
@etpinard etpinard deleted the scatter3d-scalar-hovertext-fix branch June 6, 2018 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants