Add null-data buffer fix for parcoords #2612
Conversation
src/traces/parcoords/lines.js
Outdated
| @@ -176,7 +176,7 @@ function setAttributes(attributes, sampleCount, points) { | |||
| function emptyAttributes(regl) { | |||
| var attributes = {}; | |||
| for(var i = 0; i < 16; i++) { | |||
| attributes['p' + i.toString(16)] = regl.buffer({usage: 'dynamic', type: 'float', data: null}); | |||
| attributes['p' + i.toString(16)] = regl.buffer({usage: 'dynamic', type: 'float', data: new Uint8Array()}); | |||
There was a problem hiding this comment.
Shouldn't this be new Uint8Array(0) just like you did in:
gl-vis/regl-scatter2d@c1183ef#diff-f0cb24e401db59c6759d5cb577e58cebR403
|
Looks promising - I know that problem is a bit hard to pin down, but are you able to actually see this fix a bug? Also why Is there any way we can test this? Like, if we know it's risky to initialize a |
|
@dy would you mind addressing #2612 (comment) before next Tuesday? |
Post regl-project/regl#479, situations like this one are fixed from within regl. So I'd 👎 on adding a strict-d3-esque test for this thing. That said, cross-browser testing for regl is still an open issue (cc regl-project/regl#143) so we still can't guarantee things like this won't happen again. @dy how are you planning on testing regl in different browsers during future development? |
|
@etpinard there are 4 CI options: Circle CI, sauce labs, browserstack or browserling. Ideally one of them provides open-source free account. Also that is troublesome to run all tests directly in a browser. Ideally they need splitting and limiting. Otherwise browsers just hang.
|
|
Ok. Merging this to be part of 1.38.0 ! |
Related to recent safari null-buffer fixes. Also may facilitate with #2582