-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing splom traces #2505
Merged
Merged
Introducing splom traces #2505
Changes from 15 commits
Commits
Show all changes
108 commits
Select commit
Hold shift + click to select a range
44dc3d8
:palm_tree: pie base plot module
etpinard c56e35e
[tmp] pull splom dep from github repo
etpinard 29ca0ed
lib splom
etpinard 8b5af93
first cut splom attributes and defaults
etpinard 3be9569
adapt grid and cartesian axis logic for sploms
etpinard 76c64e5
first cut splom auto axis type detection
etpinard 59588cc
first cut splom plot
etpinard 66494c7
some linting
etpinard 20f01cc
hook in splom drag
etpinard c5cda6b
add _hasOnlyLargeSploms flag
etpinard 89fb6bb
add a few DRY up TODOs
etpinard 9cac919
first cut splom defaults test
etpinard fda1b34
add two splom mocks (image generation is broken currently)
etpinard cf485b7
fixup c5cda6b
etpinard fc6c895
fixup PlotSchema.get() for splom
etpinard 7be161b
Enable hover for splom
dy 80dd61e
fixup _scene ref in calcdata stash
etpinard 0fb65dd
first pass splom basePlotModule clean step
etpinard d50746b
add splom mocks
etpinard a3c87da
fixup 0fb65dd
etpinard c4c1514
:hocho: obsolete file
etpinard 469e4cd
add regl_utils lib module
etpinard c0c5a6e
clear regl colors once per drawData pass
etpinard d02f572
clear regl colors once per drawData pass
etpinard 60df466
Add basic hover indexes calc
dy e7b02c0
more robust handling of splom in fx/hover.js
etpinard 658c529
split prepareRegl and clearGlCanvases into two modules
etpinard 2b6c58e
fix and :lock: regl-line2d grids
etpinard eab3768
Add O(N) hover
dy b6359ef
Fold hover calc
dy a37abfb
Remove compare hovermode
dy 4470447
Remove hovermode attr
dy aaa42c6
Provide selection scaffold
dy a077c3f
:hocho: (x|y)direction
etpinard f442f59
fixup autotype for splom trace w/ visible false dims
etpinard 4f68cba
make splom (x|y)axes items by 'subplotid'
etpinard 07d59d5
fix handling of splom visible false dimensions
etpinard 2a048a9
bump regl-scattermatrix
etpinard 697a127
Preven errors on non-splom traces
dy 32118b0
fixup and test splom clean method
etpinard bb11313
Fixup lines
dy 1bc95d5
swap showdiagonal -> diagonal.visible & better :books:
etpinard 419458c
manually stringify regex during PlotSchema.get()
etpinard 9162265
some DRYing in PlotSchema.get()
etpinard e14013b
make supplyTraceDefaults work again with splom
alexcjohnson 22e8c7e
Make default splom selection
dy d072121
Make rough dynamic selection
dy 02ed2eb
move doAutoRangeAndConstraints, drawData and finalDraw to subroutines
etpinard 3ad1eaa
add 'axrange' editType
etpinard bb02281
speed up doModeBar subroutines for cartesian subplots
etpinard d07ae70
improve fullLayout._has()
etpinard 468119e
speed up dragbox
etpinard 0979272
clean splom drag logic
etpinard ebb35ce
lint in plot_api
etpinard 37b585e
Handle upper/lowe halves
dy 92a37c8
bump deps
etpinard ce379a1
1st cut showupperhalf / showlowerhalf
etpinard f9090b7
(fixup) add draggedPts to scattercarpet categories
etpinard b28052b
clean splom drag logic
etpinard f2569c3
draw regl-line2d grid lines before splom on drag
etpinard b283919
better grid.(x|y)side defaults for splom
etpinard 571950e
wip work for !diagonal.visible + !show(upper|lower)half
etpinard 76d8ace
bump deps
etpinard 2d39ea7
bump regl-scatter2d dep (fix destroy method)
etpinard 7f916b0
fixups for `diagonal.visible: false`
etpinard 0c901b5
fixup i === j subplot logic and baselines
etpinard 1193e6c
update baseline (from ce379a1d7c2a335733d1c763ab06265606a86154)
etpinard 99712dd
update splom baselines (not sure why that happened?)
etpinard 129e1f2
:hocho: splom 'mode' (for now)
etpinard b2ee736
Merge branch 'splom-feature' into splom-zoom-perf
etpinard a6f2664
fixup splom attributes
etpinard 5f0c828
choose more heavy duty patch for setting mode: 'markers' in splom traces
etpinard 0d5a638
add Plotly.react test for splom :tada:
etpinard a0b2574
Merge branch 'splom-feature' into splom-zoom-perf
etpinard 7ae7159
fix and :lock: regl-line2d grid data
etpinard d4a2a53
fix and :lock: in-and-out of hasOnlyLargeSploms regime
etpinard f07ff4b
set visible:false if showupper & showlower & diagonal.visible are false
etpinard fa8adee
split image tests into 2 jobs
etpinard d3fe40d
replace selectAll with for(k in _plots) loop
etpinard cc1b3de
fixup and :lock: dragbox with linked y axes
etpinard 45266ed
fix and :lock: marker.symbol and arrayOk marker attrs
etpinard a0caefd
fix and :lock: splom on log and date axes
etpinard 2e6b610
ping imagetest before trying to create baseline img
etpinard 980855c
Merge branch 'splom-feature' into splom-zoom-perf
etpinard f7d637d
:books: link TODOs to gh issues
etpinard da81a0e
no need to stash splom grid data on fullLayout
etpinard 74abb7f
sort basePlotModules so that splom is always drawn below scattergl
etpinard 062d4a3
fixup splom + scattergl select
etpinard 978a70e
Merge pull request #2527 from plotly/splom-zoom-perf
etpinard b868959
move clearSelect to cartesian/select.js
etpinard e38a0a6
rm obsolete scattergl scene clearSelect (confirmed by @dy)
etpinard 651901d
fixup splom with cartesian mock/baseline
etpinard 9aea0ba
fixup scattergl+splom style() on select
etpinard 71a0395
try at robust subplot-to-subplot selections
etpinard 24dad16
:hocho: obsolete comment
etpinard 9d0bcfd
fixup cross-subplot select logic brought up in 71a0395
etpinard 6fd6919
fixup relayout for 'grid.(x|y)side'
etpinard 31e34fa
fix and :lock: basePlotModules sorting
etpinard a79f5dc
add splom hover/selection/drag tests
etpinard 31836f2
:pencil2: splom meta description + register grid in splom index
etpinard 6cc634a
:cow2: in various new splom code & comment
etpinard c7b81ec
typos in :books:
etpinard 8e9eaff
Merge branch 'master' into splom-feature
etpinard ad5abb6
Update deps, adapt line2d code
dy c98071f
Fix select in splom large
dy 2d93469
sub regl-splom -> regl-scattermatrix in comments
etpinard 6c5a1e7
Fix removing line passes
dy a7b08b3
clear canvas on doTicksRelayout when hasOnlyLargeSploms
etpinard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/** | ||
* Copyright 2012-2018, Plotly, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
module.exports = require('../src/traces/splom'); |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do this just based on
_module.attr
?if(Array.isArray(_module.attr)) { _module.attr.forEach(... handleBasePlotModule) }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 9162265