Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regl-based scattergl and scatterpolargl traces #2258

Merged
merged 39 commits into from
Jan 18, 2018
Merged

Regl-based scattergl and scatterpolargl traces #2258

Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
b64928d
regl-ify scattergl by dfcreative
etpinard Dec 12, 2017
70769e9
Merge branch 'master' into rescatter-squashed
etpinard Jan 5, 2018
45f9003
Merge branch 'rescatter-squashed-2018' into regl-scattergl-scatterpol…
etpinard Jan 17, 2018
a6f86db
first steps for scatterpolargl
etpinard Dec 12, 2017
0983b21
Make toSVG
dy Dec 15, 2017
2b5ee19
Handle multiple subplots selection properly
dy Jan 5, 2018
f235b0d
Fix single-color open markers
dy Jan 11, 2018
58cb8f4
Make proper fill behaviour
dy Jan 13, 2018
ab2a0a2
Fix gl2d_click & gl_plot_interact tests
dy Jan 13, 2018
0842891
reorder gl2d <-> gl3d tests
etpinard Jan 15, 2018
ed075d2
skip gl2d visibility toggle test on CI
etpinard Jan 15, 2018
69a033b
more tolerance gl2d annotation test
etpinard Jan 15, 2018
9f304e6
sort pointcloud and heatmapgl mock
etpinard Jan 15, 2018
3fbf523
update gl2d baseline images
etpinard Jan 17, 2018
1d650ac
Bump regl
dy Jan 15, 2018
91d4a75
Add multiple axes test mocks
dy Jan 15, 2018
dce0a1a
Normalize marker sizes
dy Jan 15, 2018
9f9f512
add mocks to lock scattergl fixups:
dy Jan 16, 2018
9911ba8
Fix log error bars
dy Jan 16, 2018
dc00cf1
Add gl2d layout images and shapes mock
dy Jan 16, 2018
9548cc1
add long tick labels mocks
dy Jan 16, 2018
65bd43d
ADd scatter panel test/fix
dy Jan 16, 2018
10f87a3
Add gl2d line dash test
dy Jan 16, 2018
715683f
fixup gl2d zoombox tests
etpinard Jan 17, 2018
b45e91d
try re-balancing tests in the 2 containers to reduce exec time
etpinard Jan 17, 2018
c0c0189
cleanup scattergl index exports
etpinard Jan 17, 2018
1075d87
make scatterpolar use own attributes and defaults
etpinard Jan 17, 2018
ebaf705
fix select/lasso click event + test
etpinard Jan 17, 2018
ac7db75
rm unsed dependencies and modules
etpinard Jan 17, 2018
8e3a0ba
make Plots.generalUpdatePerTraceModule consistent w/ Cartesian.plot
etpinard Jan 17, 2018
e6223b6
:palm_tree: scatterpolar <-> scatterpolargl hoverPoints
etpinard Jan 17, 2018
5ea57a3
Fix gl marker symbols logic/test
dy Jan 18, 2018
d3fd7d2
Add fill self next test
dy Jan 18, 2018
f48cc2f
Fix regl-error2d update
dy Jan 18, 2018
de7bea3
baselines for dima's last few commits
etpinard Jan 18, 2018
a237c83
add some scatterpolargl tests
etpinard Jan 18, 2018
44b0ae6
make gl2d drag test use assets/drag
etpinard Jan 18, 2018
40f60de
attempt for making polar drag test more robust
etpinard Jan 18, 2018
8bebc2e
skip polar drag test on CI (for now)
etpinard Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/traces/scattergl/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ function sceneUpdate(container, subplot) {
if(scene.fill2d) scene.fill2d.update(opts);
if(scene.scatter2d) scene.scatter2d.update(opts);
if(scene.line2d) scene.line2d.update(opts);
if(scene.error2d) scene.error2d.update([].push.apply(opts, opts));
if(scene.error2d) scene.error2d.update(opts.concat(opts));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it fixes #2259 (comment)

Thanks.

if(scene.select2d) scene.select2d.update(opts);

scene.draw();
Expand Down