Scatterpolargl #2230
Closed
Scatterpolargl #2230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and reuse Scatter.selectPoints straight up 🎉
... instead of hacky subplot ref punched during ScatterPolar.plot
- selections and hover are working - not much else
- that update `polar.radialaxis.position`
- instead of wrapping Scatter.style - make Plots.style detect if some trace module reuse the same style module.
... by moving (r,theta) computations to scatterpolar/plot
to incorporate range[0] offset.
- move setConvertAngular to helper file so that polar fx can use it - expose dblclick notifer logic in cartesian dragbox, use it in polar - rename hasClipOnAxisFalse -> _hasClipOnAxisFalse so that Drawing.hideOutsideRangePoints knows what to do with it
- we might have to restrict a few more things and tweak it for other (upcoming) angularaxis.thetaunit
|
@etpinard may I ask you to run the tests in Ubuntu machine, I cannot reproduce the CI errors locally. |
|
@dfcreative sure, I'll give it a shot at some point today. But back in 25fd2e4 from #2200, the tests passed on CI. Something must have happened since? |
|
@etpinard merged master in case. Except for switching to regl nothing changed for the matter. Not sure why I cannot reproduce these errors on windows/Chrome. |
|
Well something must have changed, commit 25fd2e4 had regl in it already. I'll looked into it. |
|
@dfcreative don't push to this branch anymore. It is non-trivially behind Please use https://github.com/plotly/plotly.js/tree/scatterpolargl-2018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2200 and #1869