Better exponent treatment beyond SI prefixes #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't round to factors of 3 - use 'power' (x10<sup>18</sup>) instead of 'e' (e+18)
alexcjohnson
commented
Aug 4, 2017
| * not a number, but for displaying numbers: the "minus sign" symbol is | ||
| * wider than the regular ascii dash "-" | ||
| */ | ||
| MINUS_SIGN: '\u2212' |
There was a problem hiding this comment.
Currently this is only used in cartesian tick labels (and hover text) and this does get reused in other places... but I suspect there are places in other plot types where we use a regular dash that should be replaced by this one.
etpinard
reviewed
Aug 7, 2017
| // 10^14 -> 100T | ||
| // 10^15 -> 1x10^15 | ||
| // 10^16 -> 1x10^16 | ||
| function beyondSI(exponent) { |
|
Solid work. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1920
In addition to no longer rounding the exponent to a factor of 3 when you get past the SI prefixes, I also changed it to
exponentformat: 'power'there - ie "×1016" instead of "e+16" as we had before. I suspect usingexponentformat: 'e'as the fallback was a decision made before we supported pseudo-html in tick labels.cc @etpinard @AndiMD