Test click event handlers #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use mouse event asset to simulation an svg2d click event - plotly_click is a combinaison of a mousemove, mousedown and mouseup mouse events - use that to inspect click event data
| function click() { | ||
| mouseEvent('mousemove', clientX, clientY); | ||
| mouseEvent('mousedown', clientX, clientY); | ||
| mouseEvent('mouseup', clientX, clientY); |
|
Good stuff 👍. It's still surprising to me that no frontend test frameworks include a mouse event simulator (to my knowledge). I suppose it could promote overuse and bad testing, but it's such a useful tool! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz @alexcjohnson @cldougl
so that #173 never happens again.
Useful resource: https://developer.mozilla.org/en/docs/Web/API/MouseEvent
The test below would have failed before the patch in #174