-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move node-sass to devdeps and remove postinstall npm command #164
Conversation
@@ -94,6 +92,7 @@ | |||
"karma-coverage": "^0.5.3", | |||
"karma-firefox-launcher": "^0.1.6", | |||
"karma-jasmine": "^0.3.6", | |||
"node-sass": "^3.4.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-daniel can you bring xml2js
down in the devDep too.
It is only used in the proprecess step:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes sorry I forgot that one! Thanks!
💃 thanks so much! |
Move node-sass to devdeps and remove postinstall npm command
@etpinard
Alrighty! So it looks like
node-sass
is a pretty hefty friend. It's not really needed for production use, but if we remove thenpm run postinstall
command, we have to check in thebuild/plotcss.js
andbuild/ploticon.js
files.One thing to note, if you make changes you'll have to run
npm run preprocess
manually, and that will update both of those assets, and you can then commit the changes.Removed those from the ignore files as well.
(not a bug, my finger slipped)