Box trace directory split into multiple files #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something's goofy here... color on gl3d surfaces seem to be wonky, but these commits haven't touched anything other than box traces. |
|
👍 All good with the updated gl-vis. |
| @@ -0,0 +1,138 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
paste the license header from another file here.
Better yet, maybe you add a no-header-found clause in https://github.com/plotly/plotly.js/blob/master/tasks/header.js#L50 to do it automatically.
There was a problem hiding this comment.
Ahh I thought there was a check to automatically insert it already. I'll do it manually right now, but that will be a good thing to add in.
|
@mdtusz looking good. Thanks for doing this. 💃 once the headers are in place and the index file is changed. |
mdtusz
added a commit
that referenced
this pull request
Jan 5, 2016
Box trace directory split into multiple files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰
Should make maintenance and such much nicer, and now it mirrors the structure of Bars.