Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.37.x doesn't ignore layout.grid: true during defaults #2633

Closed
pietersv opened this issue May 14, 2018 · 1 comment
Closed

1.37.x doesn't ignore layout.grid: true during defaults #2633

pietersv opened this issue May 14, 2018 · 1 comment
Labels
bug something broken

Comments

@pietersv
Copy link

pietersv commented May 14, 2018 •
edited
Loading

The following chart https://codepen.io/__proto__/pen/NMBpyY
renders fine in Plotly.js with CDN version up to 1.36.0 but fails in the latest release 1.37.0

Uncaught TypeError: Cannot read property 'x' of undefined
    at handlePositionDefaults (VM10186 plotly.js:132985)
    at Object.supplyLayoutDefaults (VM10186 plotly.js:132829)
    at Object.plots.supplyLayoutModuleDefaults (VM10186 plotly.js:144174)
    at Object.plots.supplyDefaults (VM10186 plotly.js:143178)
    at Object.exports.plot (VM10186 plotly.js:121060)
    at Object.exports.newPlot (VM10186 plotly.js:121496)
    at VM9694 pen.js:278

image

I didn't see any release notes for 1.37 so submitting this here in case.
@etpinard
Copy link
Contributor

Thanks for the report.

Removing grid: true from the layout object (which doesn't do anything) makes your graph render again:

https://codepen.io/etpinard/pen/bMjWjy?editors=1010

@etpinard etpinard added the bug something broken label May 14, 2018
@etpinard etpinard changed the title "Cannot read property 'x' of undefined" in latest release 1.37.x doesn't ignore layout.grid: true during defaults May 14, 2018
alexcjohnson added a commit that referenced this issue May 16, 2018
@alexcjohnson
Merge pull request #2638 from plotly/grid-mess-fix
fb75158 
fix #2633 - make sure we have a grid before attaching it to layoutOut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etpinard @pietersv