consider only splom dimensions on axis during axis autotype

- using trace._diag, this allows to support multiple axis type in splom-generated axes
plotly · Aug 13, 2018 · dd563bb · dd563bb
1 parent def6aa5
commit dd563bb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/plots/cartesian/type_defaults.js b/src/plots/cartesian/type_defaults.js
@@ -89,9 +89,10 @@ function setAutoType(ax, data) {
     }
     else if(d0.type === 'splom') {
         var dimensions = d0.dimensions;
+        var diag = d0._diag;
         for(i = 0; i < dimensions.length; i++) {
             var dim = dimensions[i];
-            if(dim.visible) {
+            if(dim.visible && (diag[i][0] === id || diag[i][1] === id)) {
                 ax.type = autoType(dim.values, calendar);
                 break;
             }

diff --git a/test/jasmine/tests/splom_test.js b/test/jasmine/tests/splom_test.js
@@ -352,8 +352,10 @@ describe('Test splom trace defaults:', function() {
         });
 
         var fullLayout = gd._fullLayout;
-        expect(fullLayout.xaxis.type).toBe('date');
-        expect(fullLayout.yaxis.type).toBe('date');
+        expect(fullLayout.xaxis.type).toBe('linear', 'fallbacks to linear for visible:false traces');
+        expect(fullLayout.yaxis.type).toBe('linear', 'fallbacks to linear for visible:false traces');
+        expect(fullLayout.xaxis2.type).toBe('date');
+        expect(fullLayout.yaxis2.type).toBe('date');
     });
 });