This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
Fix intermittent failures in updateGrid test #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved the code that can throw into a promise so that it can be handled. Fixes plotly#170
* Ensure API requests go to `https://api.plot.ly/`. Fixes failures caused by sending requests to `http://plotly.acme.com/`. * Introduce a 1 second pause between API requests. Fixes intermittent failures.
chriddyp
reviewed
Sep 5, 2017
| @@ -66,8 +72,7 @@ describe('Grid API Functions', function () { | |||
| json.cols[names[5]].data, | |||
| [130, 140, 150] | |||
| ); | |||
| done(); | |||
| })).catch(done); | |||
There was a problem hiding this comment.
Nice catch! Tthis pattern is everywhere in the tests, I'm not sure how I missed the fact that you can just return a promise. We're on an old-ish version of mocha (^2.4.5) but it seems like this was supported since 1.18.0 (https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#1180--2014-03-13, mochajs/mocha#329)
chriddyp
reviewed
Sep 5, 2017
| // Retrieve the contents from the grid | ||
| return PlotlyAPIRequest(url, {username, apiKey, method: 'GET'}); | ||
| return wait(1000).then(() => { |
There was a problem hiding this comment.
I wonder why this wait is needed (is it a plotly API issue?), but I'm OK with this 👍
chriddyp
reviewed
Sep 5, 2017
| } | ||
| ).then((res) => { | ||
| return new Promise(function(resolve) { | ||
| const {username, accessToken} = getSetting('USERS')[0]; |
|
💃 - looks good! Thanks for digging into this one :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the updateGrid test (previously skipped in order to merge #163).
This PR is merged on to top of #171.