Skip to content

Commit

Permalink
bump dependencies versions
Browse files Browse the repository at this point in the history
  • Loading branch information
Marc-André Rivet committed Mar 5, 2019
1 parent 021cbdd commit 0554546
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
'Flask>=0.12',
'flask-compress',
'plotly',
'dash_renderer>=0.19.0',
'dash-core-components>=0.43.1',
'dash-html-components>=0.13.5',
'dash-table>=3.5.0'
'dash_renderer==0.20.0',
'dash-core-components==0.44.0',
'dash-html-components==0.14.0',
'dash-table==3.6.0'

This comment has been minimized.

Sign in to view

Copy link
@moorepants

moorepants Mar 6, 2019

Contributor

I'm curious why dash now depends on dash-table. dash-table also depends on dash. So it is a circular dependency. dash-table is also listed as alpha software in the readme there. This may cause issues with the conda dependency solver down the line (I maintain the dash package on conda-forge).

This comment has been minimized.

Sign in to view

Copy link
@alexcjohnson

alexcjohnson Mar 6, 2019

Collaborator

Thanks @moorepants. We're in the process of cleaning up these dependencies - dash-table v3.6.0 stops listing dash as a dependency in fact. The goal is that, for packages we deem part of the "dash core" (which consists of dash and the 4 above packages), dash is the single entry point and we release updates to the rest of the core via updates to dash. That way users only need care about the version of dash they have installed (and indeed only need to install dash) and can be confident all the core packages will work correctly together.

Other packages that are not part of the dash core - such as dash-daq and dash-bio - will continue to list dash as a dependency.

Thanks for bringing up the alpha description. cc @Marc-Andre-Rivet we should probably change that language at this point?

This comment has been minimized.

Sign in to view

Copy link
@moorepants

moorepants Mar 6, 2019

Contributor

Thanks for the update. Sounds like a good plan forward.
],
entry_points={
'console_scripts': [
Expand Down

0 comments on commit 0554546

Please sign in to comment.