Add support for clim (contrast limits) #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready. There is still a minor issue that the full-res slice is not loaded when auto-reloading (in debug mode). But this bug was already present before this PR, and can fix it later. |
emmanuelle
reviewed
Dec 17, 2020
| indices = [slice(None), slice(None), slice(None)] | ||
| indices[self._axis] = index | ||
| im = self._volume[tuple(indices)] | ||
| return (im.astype(np.float32) * (255 / im.max())).astype(np.uint8) |
There was a problem hiding this comment.
If I understand well, before having clim the contrast could vary as the slice changed, since the max of the slice was used?
There was a problem hiding this comment.
Nicely spotted! Yes, it did. I think I originally meant to scale to the volume min/max, but accidentally used the im instead.
emmanuelle
reviewed
Dec 17, 2020
|
|
||
|
|
||
| @app.callback(Output(slicer.clim.id, "data"), [Input("clim-slider", "value")]) | ||
| def update_clim(value): |
emmanuelle
approved these changes
Dec 17, 2020
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.