-
-
Notifications
You must be signed in to change notification settings - Fork 145
Conversation
- clean up `publish` - remove redundant version.py - remove dev build - remove artefacts and old versions of plotlyjs
Do we use the copied For now since we already have this pattern in table, fine to expand it. But perhaps with |
Agreed. I kept it because my understanding was that R uses it. @rpkyle? |
AFAICT R only uses the base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 Nicely done 💣
@alexcjohnson Actual back on your comment
We do not, the only other usage is done with the root Update on |
# Conflicts: # dash_core_components/dash_core_components.dev.js # dash_core_components/dash_core_components.dev.js.map # dash_core_components/version.py
dev
build was useful before we used external source maps on the prod build -- prod and dev are now redundant as the source map is always availablepackage-info.json
in the dash_core_components/ dist folder to allow normal npm publish to work (like in table)files
in package.json instead of blacklisting through .gitgnore / .npmignore (like in table)package-info.json
andpackage.json
(setup.py) instead ofversion.py
(like in table)setup.py
content frompackage.json
(like in table)Tagging @rpkyle as this may impact the R generation in ways I don't understand :)