Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Only enable percy for one container. #295

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Conversation

T4rk1n
Copy link
Contributor

@T4rk1n T4rk1n commented Sep 7, 2018

Only run percy in python 2.7, plotly/dash#370.

@rmarren1
Copy link
Contributor

rmarren1 commented Sep 7, 2018

@valentijnnieman I think those changes are because you published #256, can you confirm? If so 💃

@valentijnnieman
Copy link
Contributor

valentijnnieman commented Sep 12, 2018

@T4rk1n It should be fine. Because the Graphs in the tests haven't specified width, plotly.js will calculate it for us - it looks like in this test test_tabs_render_without_selected, maybe because of the slightly weird structure, it renders them different now.

Copy link
Contributor

@valentijnnieman valentijnnieman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me nonetheless 💃

@T4rk1n T4rk1n merged commit 29d9f1d into master Sep 12, 2018
@T4rk1n T4rk1n deleted the fix-percy-multi-build branch September 12, 2018 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants