Add loading animation for save and edit buttons. #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pgrunewald thank you! Could you please add a changelog for this? |
pgrunewald
force-pushed
the
loading-animation-submit-buttons
branch
from
2efb8c6 to
da9d88c
Compare
pgrunewald
force-pushed
the
loading-animation-submit-buttons
branch
from
da9d88c to
ebdbbe8
Compare
|
Also all conflicts should be resolved. This is not been noticed either. Maybe someone can look into this or give me a hint? /cc @tisto @sneridagh |
|
Thanks @pgrunewald , merged and included in the upcoming alpha.12! |
sneridagh
added a commit
that referenced
this pull request
Nov 13, 2019
* master: (34 commits) Back to development Release 4.0.0-alpha.12 Amend changelog Change to official Plone docker image in the docs Add loading animation for save and edit buttons. (#956) Set Cypress viewport width to 1280px. (#968) Move Body class depending on content type to App component in order to make it available everywhere, Add root class name to Tags component (#1006) Update last remainings of the old image Update versions Update README and docs Small i18n fixes (#1003) Improve upgrade guide Back to development Release 4.0.0-alpha.11 Slight fix on OB improvement (#1002) Improved ObjectBrowser API to allow arbitrary field names and a custo… (#1000) Fix ability to develop Volto itself (as and addon with a mrs.developer checkout) inside a Volto project (#1001) Add internationalization section to docs. (#964) improve documentation for Icon component (#996) Fix icon in TextWidget (#974) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #943
I found that the submit button for save and edit are the only ones, where noticable loading times can be expected. I looked into other places (like site setup), but there we have already the loading animation.
cc: @tisto @sneridagh