Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade react and react-dom to 16.12.0 #1008

Merged
merged 5 commits into from
Nov 23, 2019
Merged

Upgrade react and react-dom to 16.12.0 #1008

merged 5 commits into from
Nov 23, 2019

Conversation

pnicolli
Copy link
Contributor

There are some quality of life upgrades that would be a nice addition, plus this would fix the warnings in the loadable components testing (see #967).

For example:

  • Add support for editing useState state from DevTools.
  • Warn when setState is called from useEffect, creating a loop.
  • Report Hook calls at the top level as a violation.

See more here:
https://github.com/facebook/react/blob/master/CHANGELOG.md

@tisto tisto self-requested a review November 14, 2019 21:26
@pnicolli pnicolli changed the title Upgrade react and react-dom to 16.11.0 Upgrade react and react-dom to 16.12.0 Nov 18, 2019
@pnicolli
Copy link
Contributor Author

Upgraded directly to react 16.12.0 which was released right after opening the PR

@sneridagh
Copy link
Member

Findings while upgrading:
Helmet seems pretty unmaintained, and because of it, a warning is logged in the console because they are using an old version of react-side-effect. I opened this:
nfl/react-helmet#490

We can fork it internally in Volto, the code is quite short.

Regarding semantic-ui-react... have you seen this?
https://github.com/microsoft/fluent-ui-react
https://github.com/microsoft/fluent-ui-react/blob/master/MANIFESTO.md
It seems that someone at MS is refactoring stardustUI which in turn is a fork on semantic UI, however the project is ongoing but it's based on React Semantic UI... However, something that we have to follow.

However, all the semantic ui theming is lost as we know it.

@sneridagh sneridagh merged commit c70d9fd into master Nov 23, 2019
@sneridagh sneridagh deleted the react16_11 branch November 23, 2019 12:10
@sneridagh sneridagh mentioned this pull request Nov 23, 2019
Closed
sneridagh added a commit that referenced this pull request Nov 23, 2019
@sneridagh
Merge branch 'master' into listing-tile
395adce 
* master:
  Back to development
  Release 4.0.0-alpha.13
  Upgrade react and react-dom to 16.12.0 (#1008)
sneridagh added a commit that referenced this pull request Nov 24, 2019
@sneridagh
Merge branch 'master' into properprettierstylelint
0327712 
* master:
  Back to development
  Release 4.0.0-alpha.13
  Upgrade react and react-dom to 16.12.0 (#1008)
sneridagh added a commit that referenced this pull request Dec 2, 2019
@sneridagh
Merge branch 'master' into lodashexp
ba54e3c 
* master: (53 commits)
  Fix small CSS issues in Blocks (#1023)
  Forked `react-helmet` since it seems unmaintained. Now it's a Named import in helpers (#1025)
  Solvepeerdependencies (#1026)
  Fix to a good know digest (#1022)
  Back to development
  Release 4.0.0-alpha.15
  Export the resetContent action (#1017)
  Remove @testing-library/cypress dep, as it breaks builds if the inter… (#1018)
  Minorcssfixes (#1016)
  Back to development
  Release 4.0.0-alpha.14
  More on upgrading to a14
  Proper config for stylelint-prettier integration, add husky integration and scripts for stylelint, review rules (#1012)
  Update outdated yarn.lock.
  Back to development
  Release 4.0.0-alpha.13
  Upgrade cypress to 3.6.1.
  Upgrade react and react-dom to 16.12.0 (#1008)
  Upgrade autoprefixer, remove deprecated browsers option, move to browserlist in package.json (#1007)
  Back to development
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisto tisto tisto approved these changes

@sneridagh sneridagh sneridagh approved these changes

Assignees
No one assigned
Labels
04 type: enhancement 24 status: ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnicolli @sneridagh @tisto