Skip to content

Commit

Permalink
fix changelog entry
Browse files Browse the repository at this point in the history
  • Loading branch information
@cekk
cekk committed Apr 18, 2019
1 parent 514a377 commit f78aba5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion news/76.feature
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Change scale method logic: don't return a redundant title attr for images, but set `alt` attribute from a new alt_text field.
Change tag method logic: don't return a useless title attr for images, but set `alt` attribute from a new alt_text field.
[cekk]

1 comment on commit f78aba5

@jenkins-plone-org
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cekk Jenkins CI reporting about code analysis
See the full report here: https://jenkins.plone.org/job/package-plone.namedfile/6/violations

plone/namedfile/handler.py:11:23: C812 missing trailing comma
plone/namedfile/file.py:267:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/file.py:308:9: Q001 Remove bad quotes from multiline string.
plone/namedfile/scaling.py:192:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:195:5: C901 'DefaultImageScalingFactory.__call__' is too complex (15)
plone/namedfile/scaling.py:202:25: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:242:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:407:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:434:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:446:25: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:460:21: C816 missing trailing comma in Python 3.6+
plone/namedfile/scaling.py:486:29: C815 missing trailing comma in Python 3.5+
plone/namedfile/scaling.py:500:17: C816 missing trailing comma in Python 3.6+
plone/namedfile/interfaces.py:17:25: C812 missing trailing comma
plone/namedfile/testing.py:5:1: I004 isort found an unexpected blank line in imports
plone/namedfile/testing.py:18:9: D001 found xmlconfig.file( replace it with self.loadZCML(
plone/namedfile/tests/test_scaling.py:85:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:102:80: E501 line too long (81 > 79 characters)
plone/namedfile/tests/test_scaling.py:133:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:156:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:178:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:200:80: E501 line too long (86 > 79 characters)
plone/namedfile/tests/test_scaling.py:469:1: W293 blank line contains whitespace
plone/namedfile/tests/test_scaling.py:477:80: E501 line too long (93 > 79 characters)
plone/namedfile/tests/test_image.py:25:80: E501 line too long (80 > 79 characters)
plone/namedfile/tests/test_blobfile.py:40:31: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:45:35: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:50:46: C812 missing trailing comma
plone/namedfile/tests/test_blobfile.py:55:32: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:112:28: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:142:70: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:149:76: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:160:74: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:193:75: C812 missing trailing comma
plone/namedfile/tests/test_scaling_functional.py:198:78: C812 missing trailing comma
plone/namedfile/tests/test_doctests.py:26:17: Q000 Remove bad quotes.
plone/namedfile/tests/test_doctests.py:26:30: Q000 Remove bad quotes.
plone/namedfile/tests/test_doctests.py:47:10: C812 missing trailing comma
plone/namedfile/utils/tiff_utils.py:11:1: C901 'process_tiff' is too complex (11)
plone/namedfile/utils/tiff_utils.py:20:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:81:7: T000 Todo note found.
plone/namedfile/utils/tiff_utils.py:82:7: T000 Todo note found.
plone/namedfile/utils/__init__.py:84:66: C812 missing trailing comma
plone/namedfile/utils/__init__.py:151:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:156:73: C812 missing trailing comma
plone/namedfile/utils/__init__.py:176:15: T000 Todo note found.
plone/namedfile/utils/__init__.py:183:18: C812 missing trailing comma
plone/namedfile/utils/__init__.py:188:1: C901 'rotate_image' is too complex (20)
plone/namedfile/utils/__init__.py:219:14: C812 missing trailing comma

Follow these instructions to reproduce it locally.

Please sign in to comment.