Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename distribution from classic to classic-ui (preferred) or classicui #18

Open
stevepiercy opened this issue Nov 5, 2024 · 15 comments

Comments

@stevepiercy
Copy link

classic is not its correct name. classic-ui (preferred) or classicui would be more correct.

See plone/documentation#1733 (comment).

Edit https://github.com/plone/plone.classicui/blob/main/src/plone/classicui/distributions.zcml#L7.

@davisagli
Copy link
Member

Personally, unlike the volto distribution, I don't think this one is worth the effort to change. It's mostly an internal identifier. (I would agree with removing it from the launch page.) And a distribution encompasses more than just frontend settings, so it's sort of correct to not include UI in the name.

@stevepiercy
Copy link
Author

Maybe we call it base or core instead of classic?

What else goes into this distribution? It sounds like it is only those pieces that are required to run Plone, plus Classic UI bits. Looking into the future and reading the road map for Plone 7, it sounds like this distribution will become Plone core only, and a new distribution called classic-ui would be base + Classic UI bits and pieces.

Finally, when people say "classic", they mean Classic UI.

@mauritsvanrees
Copy link
Member

No, in Plone 7 the classic distribution will be roughly the same as now. It will keep pulling in or activating code that CMFPlone 7 no longer does. For example it would still pull in the Barceloneta theme, where CMFPlone 7 might not.
No base distribution is planned. Not by me anyway. 😁

@davisagli
Copy link
Member

Finally, when people say "classic", they mean Classic UI.

I don't understand why you see these in conflict. The distribution named classic is the one which sets up a Plone site with the Classic UI.

@stevepiercy
Copy link
Author

The distribution named classic is the one which sets up a Plone site with the Classic UI.

I mean when people verbally say "classic", they mean "Classic UI", because the latter can be a mouthful. In code and writing, we should use more care.

So let's call it buy its proper name of classic-ui. classic is a lazy shorthand. Even though it is only an internal identifier, the identifier appears in the docs.

@davisagli
Copy link
Member

I still disagree. The distribution sets up the classic configuration of Plone in both backend and frontend aspects; it's not only about the UI.

@stevepiercy
Copy link
Author

OK, then let's call it anything but "classic", because now you bring in "frontend" which also means "Volto" or "Classic UI".

Any of these names are more accurate. If none are satisfactory, we can look up terms in a synonym reference.

  • plone
  • configuration
  • plone-configuration
  • base
  • core

@davisagli
Copy link
Member

OK, then let's call it anything but "classic", because now you bring in "frontend" which also means "Volto" or "Classic UI".]

Indeed. Using this distribution is making a choice about both the backend and frontend. It sets both of them up in the classic way. This is why classic is a fitting name.

plone
configuration
plone-configuration

These are way too general and say nothing useful about what this distribution is.

base
core

It is NOT just the core, it is the core configured with the Classic UI and with related backend choices such as enabling portlets and the Folder content type.

@davisagli
Copy link
Member

@stevepiercy I think we should probably have a real-time conversation about this, since we seem to be speaking past each other. I'm not available today.

@stevepiercy
Copy link
Author

The word "classic" by itself is a problem. "classic way" is also a loaded term. TBH, the choice of "Classic UI" was also a mistake that we're now stuck with. "classic" is associated with "Classic UI", which excludes "Volto".

That's the problem.

I'm trying to come up with alternatives that do not use the already misused and abused word or term "classic".

  • basic
  • starter
  • essential

@davisagli
Copy link
Member

Can you explain how "classic" and "classic way" are problems? This is what we decided as a community to call the way that Plone sites were built before Volto was created, so your strong reaction here is catching me by surprise. I get how calling the Volto distribution "default" is loaded and I agree we should change that. I don't get why "classic" is a problem. To me it has positive connections: it's proven, stable, etc.

All your alternative proposals seem to be missing the mark to me so far. Classic Plone isn't basic or starter or essential; you can build a full, complex site with it just like you can with Volto.

@stevepiercy
Copy link
Author

I've never heard "classic" used for anything beside a shortened version of "Classic UI". Why not just call it "plone" and not "classic whatever"?

@davisagli
Copy link
Member

@stevepiercy Because both distributions are Plone and we're trying to make a distinction here.

@davisagli
Copy link
Member

@stevepiercy I'm going to revise my position and say I don't have any big objection to changing the distribution name from "classic" to "classic-ui". The different customizations made in both built-in distributions are primarily about supporting one of the 2 frontends, so it does make some sense to give them names based on the frontend names. Earlier I was thinking it might be better to have the distributions named something else to reduce confusion, but it clearly doesn't, and that's inconsistent with what how we're planning to rename default to volto in plone.volto. So sure, I guess we can name the distributions after the frontends and say "the Classic UI distribution" or "the Volto distribution" when we need to clarify.

@stevepiercy
Copy link
Author

@davisagli thank you for your patience with me. I was struggling with understanding what is and is not included. I'll work on this issue, following your example on the Volto one. As a bonus, I'll learn some details about how to create or modify a distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants