-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename distribution from classic
to classic-ui
(preferred) or classicui
#18
Comments
Personally, unlike the volto distribution, I don't think this one is worth the effort to change. It's mostly an internal identifier. (I would agree with removing it from the launch page.) And a distribution encompasses more than just frontend settings, so it's sort of correct to not include UI in the name. |
Maybe we call it What else goes into this distribution? It sounds like it is only those pieces that are required to run Plone, plus Classic UI bits. Looking into the future and reading the road map for Plone 7, it sounds like this distribution will become Plone core only, and a new distribution called Finally, when people say "classic", they mean Classic UI. |
No, in Plone 7 the classic distribution will be roughly the same as now. It will keep pulling in or activating code that CMFPlone 7 no longer does. For example it would still pull in the Barceloneta theme, where CMFPlone 7 might not. |
I don't understand why you see these in conflict. The distribution named |
I mean when people verbally say "classic", they mean "Classic UI", because the latter can be a mouthful. In code and writing, we should use more care. So let's call it buy its proper name of |
I still disagree. The distribution sets up the classic configuration of Plone in both backend and frontend aspects; it's not only about the UI. |
OK, then let's call it anything but "classic", because now you bring in "frontend" which also means "Volto" or "Classic UI". Any of these names are more accurate. If none are satisfactory, we can look up terms in a synonym reference.
|
Indeed. Using this distribution is making a choice about both the backend and frontend. It sets both of them up in the classic way. This is why classic is a fitting name.
These are way too general and say nothing useful about what this distribution is.
It is NOT just the core, it is the core configured with the Classic UI and with related backend choices such as enabling portlets and the Folder content type. |
@stevepiercy I think we should probably have a real-time conversation about this, since we seem to be speaking past each other. I'm not available today. |
The word "classic" by itself is a problem. "classic way" is also a loaded term. TBH, the choice of "Classic UI" was also a mistake that we're now stuck with. "classic" is associated with "Classic UI", which excludes "Volto". That's the problem. I'm trying to come up with alternatives that do not use the already misused and abused word or term "classic".
|
Can you explain how "classic" and "classic way" are problems? This is what we decided as a community to call the way that Plone sites were built before Volto was created, so your strong reaction here is catching me by surprise. I get how calling the Volto distribution "default" is loaded and I agree we should change that. I don't get why "classic" is a problem. To me it has positive connections: it's proven, stable, etc. All your alternative proposals seem to be missing the mark to me so far. Classic Plone isn't basic or starter or essential; you can build a full, complex site with it just like you can with Volto. |
I've never heard "classic" used for anything beside a shortened version of "Classic UI". Why not just call it "plone" and not "classic whatever"? |
@stevepiercy Because both distributions are Plone and we're trying to make a distinction here. |
@stevepiercy I'm going to revise my position and say I don't have any big objection to changing the distribution name from "classic" to "classic-ui". The different customizations made in both built-in distributions are primarily about supporting one of the 2 frontends, so it does make some sense to give them names based on the frontend names. Earlier I was thinking it might be better to have the distributions named something else to reduce confusion, but it clearly doesn't, and that's inconsistent with what how we're planning to rename |
@davisagli thank you for your patience with me. I was struggling with understanding what is and is not included. I'll work on this issue, following your example on the Volto one. As a bonus, I'll learn some details about how to create or modify a distribution. |
classic
is not its correct name.classic-ui
(preferred) orclassicui
would be more correct.See plone/documentation#1733 (comment).
Edit https://github.com/plone/plone.classicui/blob/main/src/plone/classicui/distributions.zcml#L7.
The text was updated successfully, but these errors were encountered: