-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document distributions in the 6.1 upgrade guide. #1733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an initial review. I have more work to do, so please do not merge until I have a chance. Thank you!
docs/backend/upgrading/version-specific-migration/images/zope-root-distributions.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs! I edited them to clarify a few things, add a few enhancements, and style.
However I still have one critical concern that I firmly believe should be addressed prior to the final release of 6.1: there are no usage docs! I cannot stress enough the importance of this, and I hope my fellow Plonistas agree.
Aside from that, it would be good for several other pairs of eyes review my revisions.
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
If you need an export/import for upgrading Plone you would still use collective.exportimport. Upgrading is not a use case that plone.exportimport covers.
Sure, the Python package of an add-on must be installed before you can activate it, but the same is true for a distribution. The plone.classicui distribution has basically the same Python package dependencies as CMFPlone, although it activates a few extra ones automatically if they are available (say plone.app.caching).
Just checking. What do you mean with "usage docs" in this case? Usage docs specifically for distributions, so how to create a new distribution and how to create a site with a distribution, integrating this with the installation docs? Or end user documentation of Plone as a whole? |
Specifically usage of |
BTW, the user manual is in a sad state, but at least we have a PLIP: plone/Products.CMFPlone#3987 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of big concerns and questions, and the rest minor grammar fixes.
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
@mauritsvanrees @stevepiercy This is the upgrade guide, so the audience is people who are upgrading an existing site, not creating a new one. I think it would help if we break thing apart into a few different pages:
I can help prepare these changes if they sound good. Let me know what you think. |
That sounds good to me. |
@davisagli yes, please! I was struggling with the content straddling multiple axes of the Diataxis Framework, and I think you got it all laid it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review by pushing commits.
I made a few comments and asked some questions.
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
docs/backend/upgrading/version-specific-migration/upgrade-to-61.md
Outdated
Show resolved
Hide resolved
…1.md Co-authored-by: David Glick <[email protected]>
Move Admin Guide before Developer Guide in main navigation
@davisagli I've resolved merge conflicts and made a few changes. Would you please review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevepiercy LGTM.
Co-authored-by: David Glick <[email protected]>
Thanks a lot for picking this up, @davisagli and @stevepiercy ! |
See plone/Products.CMFPlone#3854
📚 Documentation preview 📚: https://plone6--1733.org.readthedocs.build/