Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document distributions in the 6.1 upgrade guide. #1733

Merged
merged 42 commits into from
Nov 5, 2024

Conversation

mauritsvanrees
Copy link
Member

@mauritsvanrees mauritsvanrees commented Oct 8, 2024

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an initial review. I have more work to do, so please do not merge until I have a chance. Thank you!

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs! I edited them to clarify a few things, add a few enhancements, and style.

However I still have one critical concern that I firmly believe should be addressed prior to the final release of 6.1: there are no usage docs! I cannot stress enough the importance of this, and I hope my fellow Plonistas agree.

Aside from that, it would be good for several other pairs of eyes review my revisions.

stevepiercy and others added 7 commits October 8, 2024 21:39
If you need an export/import for upgrading Plone you would still use collective.exportimport.
Upgrading is not a use case that plone.exportimport covers.
Sure, the Python package of an add-on must be installed before you can activate it, but the same is true for a distribution.
The plone.classicui distribution has basically the same Python package dependencies as CMFPlone, although it activates a few extra ones automatically if they are available (say plone.app.caching).
@mauritsvanrees
Copy link
Member Author

However I still have one critical concern that I firmly believe should be addressed prior to the final release of 6.1: there are no usage docs! I cannot stress enough the importance of this, and I hope my fellow Plonistas agree.

Just checking. What do you mean with "usage docs" in this case? Usage docs specifically for distributions, so how to create a new distribution and how to create a site with a distribution, integrating this with the installation docs? Or end user documentation of Plone as a whole?

@stevepiercy
Copy link
Contributor

Just checking. What do you mean with "usage docs" in this case?

Specifically usage of plone.distribution, primarily for developers.

@stevepiercy
Copy link
Contributor

BTW, the user manual is in a sad state, but at least we have a PLIP: plone/Products.CMFPlone#3987

@stevepiercy stevepiercy mentioned this pull request Oct 9, 2024
16 tasks
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of big concerns and questions, and the rest minor grammar fixes.

@davisagli
Copy link
Member

@mauritsvanrees @stevepiercy This is the upgrade guide, so the audience is people who are upgrading an existing site, not creating a new one.

I think it would help if we break thing apart into a few different pages:

  1. A conceptual guide "Plone distributions" which explains what a distribution is (i.e. this section from the plone.distribution readme: https://github.com/plone/plone.distribution/?tab=readme-ov-file#what-is-a-plone-distribution) and the packages in Plone that are related to distributions (i.e. lines 130-135 here)
  2. A how-to guide "Create a Plone site" which shows how to add a Plone site to an existing instance (regardless of how it was installed). This can be adapted from lines 137-148 here. I think it should go in the new Admin Guide which I am working on in Start Admin Guide, revamp install/getting started #1746
  3. A how-to guide "Create a Plone distribution" which explains how to create a new Plone distribution. This can be mostly copied from the plone.distribution readme. I think it should go in the new Developer Guide.
  4. This section of the upgrade guide can focus on the optional changes that can be made to an existing site (i.e. lines 158-178 here.

I can help prepare these changes if they sound good. Let me know what you think.

@mauritsvanrees
Copy link
Member Author

That sounds good to me.

@stevepiercy
Copy link
Contributor

@davisagli yes, please! I was struggling with the content straddling multiple axes of the Diataxis Framework, and I think you got it all laid it.

Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review by pushing commits.

I made a few comments and asked some questions.

docs/install/add-site.md Outdated Show resolved Hide resolved
docs/install/index.md Outdated Show resolved Hide resolved
docs/developer-guide/create-a-distribution.md Show resolved Hide resolved
docs/conceptual-guides/distributions.md Outdated Show resolved Hide resolved
docs/conceptual-guides/distributions.md Show resolved Hide resolved
docs/developer-guide/create-a-distribution.md Show resolved Hide resolved
docs/install/add-site.md Outdated Show resolved Hide resolved
@stevepiercy
Copy link
Contributor

@davisagli I've resolved merge conflicts and made a few changes. Would you please review it again?

stevepiercy
stevepiercy previously approved these changes Nov 5, 2024
davisagli
davisagli previously approved these changes Nov 5, 2024
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy LGTM.

docs/developer-guide/index.md Show resolved Hide resolved
@stevepiercy stevepiercy merged commit 16f3bb4 into 6.0 Nov 5, 2024
1 of 3 checks passed
@stevepiercy stevepiercy deleted the maurits-upgrade-61-distributions branch November 5, 2024 23:36
@mauritsvanrees
Copy link
Member Author

Thanks a lot for picking this up, @davisagli and @stevepiercy !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants