Allow to disable rule caching by setting "DIAZO_ALWAYS_CACHE_RULES" t… #245
Conversation
…o a value which evaluates to False.
|
@thet thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
| @@ -55,13 +51,13 @@ def develop_theme(self): | |||
| return False | |||
| if self.debug_theme(): | |||
| return True | |||
| if environ.get("DIAZO_ALWAYS_CACHE_RULES"): | |||
| if utils.is_truthy(environ.get("DIAZO_ALWAYS_CACHE_RULES", False)): | |||
There was a problem hiding this comment.
^^ This is the actual change.
|
One Jenkins failure, but it is unrelated: browser cannot be found. |
| @@ -43,6 +43,11 @@ | |||
| LOGGER = logging.getLogger("plone.app.theming") | |||
|
|
|||
|
|
|||
| def is_truthy(value): | |||
| """Return `true`, if value is truthy.""" | |||
| return value and str(value).lower() in ("1", "y", "yes", "t", "true") | |||
There was a problem hiding this comment.
First of all, I would rather check for "falsish" values.
That would handle cases where somebody set DIAZO_ALWAYS_CACHE_RULES to on or enabled.
On the other end, there is already some code doing something similar:
Then I would not add a helper function for this.
But if you really have to, avoid to handling types that are not strings or call it with another name... is_truthy(2) will return False which is not immediately clear.
…o a value which evaluates to False.
@gforcada this is not yet finished as this might even be a breaking change. therefore I sumitted this more to discuss than to review.
I was hit today again by this setting.
I have a installation where the setting
DIAZO_ALWAYS_CACHE_RULES trueis present. I checkedparts/instance/zope.confand set it toFalsewithout any effect.AFAIK there are some environment variable which only need to be defined where the actual value isn't considered. IMO the value should have an effect on the setting.