Backport 4K x 4K windows to 1.3.x #111
Conversation
# Conflicts: # news/110.bugfix
# Conflicts: # news/110.bugfix
|
@Rotonen thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
I'm currently not figuring out what is different about the Travis build on this branch vs. the master. The relevant files in this repository do not seem to have changed and the issue is a Java stack trace at test setup, where it tries to connect to some (probably Windows based) remote browser. Could it be something like the Travis-side credentials / config of Saucelabs for this branch? |
|
This project has Travis setup for running Selenium tests with Sauce Labs as an example. But there is no other real reason for that. Maybe it is time to tear that down? By removing ROBOT_REMOTE_URL and the build matrix and sauce add-on from travis configuration? |
|
Would that break the testing on IE we have going on? Astonishingly that's the only thing green on Travis currently. |
|
Yes it would 🙈 |
|
I'd rather figure out what's up and fix it than throw that away and I'm not in a particular hurry either. |
Fixes #100
|
I've now also cherry-picked 2c6ad4b onto this branch, which has rejuvenated the main Travis builds, but now the IE builds get stuck and time out. |
|
Upon inspecting the history of the IE builds, they're just flaky. So they're actually fine as they now are. @jenkins-plone-org please run jobs |
Backport of #110