-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include vocabulary token #107
base: master
Are you sure you want to change the base?
Conversation
@jackahl thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
@jensens @ksuess proposed to change the returned data to |
So, @ksuess is right, this would be clean: No value at on the declarative level, lookup when needed at the server side. Since the original implementation is wrong and in use now, this would be a really breaking change with a lot of implications, also in bunch . I would rather keep the existing code and implement a new method, then changing piece by piece the other parts, but in non-breaking way, deprecating the usage of the old way. I think we first solve the problem the "stop-gap" way. The other solution needs way more effort and probably something like a PLIP summarizing the whole. |
fix for #106
merge plone/plone.restapi#1403 first.