Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Plone 6.1 constraints in tox to avoid circular dependency error in Plone 6.0 #131

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

wesleybl
Copy link
Member

@wesleybl wesleybl commented Oct 10, 2024

@mister-roboto
Copy link

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@wesleybl
Copy link
Member Author

@mauritsvanrees @gforcada even though I removed the circular job in .meta.toml it still ran. Did I do something wrong?

@wesleybl
Copy link
Member Author

hum I need to run meta again after updating .meta.toml

@wesleybl wesleybl changed the title Does not run curlular job on github action Does not run curlular job on github actions Oct 10, 2024
@davisagli
Copy link
Member

@wesleybl This PR targets the master branch, but Plone 6.0 uses the 5.x branch. This change shouldn't be needed for Plone 6.1, which does not have the circular dependency problem. Right?

@wesleybl wesleybl changed the title Does not run curlular job on github actions Use Plone 6.1 constraints in tox to avoid circular dependency error in Plone 6.0 Oct 16, 2024
@wesleybl
Copy link
Member Author

@davisagli I changed the PR to use Plone 6.1 constraints, where the circular dependency problem does not exist.

@wesleybl wesleybl requested a review from davisagli October 16, 2024 14:09
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleybl Thanks!

@davisagli davisagli merged commit e517696 into master Oct 16, 2024
10 of 12 checks passed
@davisagli davisagli deleted the circular branch October 16, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants