-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Plone 6.1 constraints in tox to avoid circular dependency error in Plone 6.0 #131
Conversation
@wesleybl thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@mauritsvanrees @gforcada even though I removed the circular job in |
hum I need to run meta again after updating |
@wesleybl This PR targets the master branch, but Plone 6.0 uses the 5.x branch. This change shouldn't be needed for Plone 6.1, which does not have the circular dependency problem. Right? |
@davisagli I changed the PR to use Plone 6.1 constraints, where the circular dependency problem does not exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wesleybl Thanks!
See: plone/plone.formwidget.recaptcha#37 (comment)