-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove plone.app.iterate profile #99
Comments
See plone/plone.app.iterate#99 There used to be only a `plone.app.iterate:plone.app.iterate` profile. This was kept for backwards compatibility, but copied to a `plone.app.iterate:default` profile, as is usual. We want to remove the old profile definition, but this might give problems when someone still has this installed instead of the default profile. Later we may want to do something similar with CMFPlacefulWorkflow. See plone/Products.CMFPlacefulWorkflow#38 But this has no default profile yet.
Done, right? |
No, the |
I checked by hacking the current profiles a bit, and it should be fine to remove the old profile name completely, also if the upgrade step in Specifically, if the
So should be safe to remove, but let's wait until 6.1. I have just now created a project for Plone 6.1 and this is the first item on it: |
See #99 (comment). This is for Plone 6.1 only. Needs a small fix in plone.app.upgrade for good measure.
There is still a
plone.app.iterate:plone.app.iterate
profile, which is the original copy of thedefault
profile.It is referenced in the add-on list in CMFPlone, but I have removed it in a pending PR. We should do the same in CMFPlone 5.2.
When migrating from Plone 5.0.2 or earlier, users may have
plone.app.iterate:plone.app.iterate
installed, instead of the default profile. We should have an upgrade step to fix this. Maybe just reuse the single existing upgrade step in this package, which reinstalls itself. Or we could do this inplone.app.upgrade
, as it might get a bit confusing in here.For backwards compatibility, it is probably best to keep the
plone.app.iterate
profile in Plone 5.2. But the upgrade step could already be done.The text was updated successfully, but these errors were encountered: