Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove plone.app.iterate profile #99

Closed
mauritsvanrees opened this issue Sep 13, 2021 · 3 comments
Closed

Remove plone.app.iterate profile #99

mauritsvanrees opened this issue Sep 13, 2021 · 3 comments

Comments

@mauritsvanrees
Copy link
Member

There is still a plone.app.iterate:plone.app.iterate profile, which is the original copy of the default profile.
It is referenced in the add-on list in CMFPlone, but I have removed it in a pending PR. We should do the same in CMFPlone 5.2.

When migrating from Plone 5.0.2 or earlier, users may have plone.app.iterate:plone.app.iterate installed, instead of the default profile. We should have an upgrade step to fix this. Maybe just reuse the single existing upgrade step in this package, which reinstalls itself. Or we could do this in plone.app.upgrade, as it might get a bit confusing in here.

For backwards compatibility, it is probably best to keep the plone.app.iterate profile in Plone 5.2. But the upgrade step could already be done.

mauritsvanrees added a commit to plone/plone.app.upgrade that referenced this issue Mar 21, 2023
See plone/plone.app.iterate#99
There used to be only a `plone.app.iterate:plone.app.iterate` profile.
This was kept for backwards compatibility, but copied to a `plone.app.iterate:default` profile, as is usual.
We want to remove the old profile definition, but this might give problems when someone still has this installed instead of the default profile.

Later we may want to do something similar with CMFPlacefulWorkflow.
See plone/Products.CMFPlacefulWorkflow#38
But this has no default profile yet.
@gforcada
Copy link
Member

Done, right?

@mauritsvanrees
Copy link
Member Author

mauritsvanrees commented Mar 27, 2023

No, the plone.app.iterate:plone.app.iterate profile is still there. But when it was already installed, it will now be cleanly marked as not installed, and replaced by the default profile instead. We can remove the actual profile in either 6.1 or 7.0.

@mauritsvanrees
Copy link
Member Author

I checked by hacking the current profiles a bit, and it should be fine to remove the old profile name completely, also if the upgrade step in plone.app.upgrade to fix the confusion has not been run yet.

Specifically, if the plone.app.iterate:plone.app.iterate was installed, but is not available anymore, then the upgrade step works just fine:

  • The code sees that the plone.app.iterate:plone.app.iterate profile is installed.
  • It marks it as uninstalled.
  • It applies the default profile of the package.

So should be safe to remove, but let's wait until 6.1.

I have just now created a project for Plone 6.1 and this is the first item on it:
https://github.com/orgs/plone/projects/25/views/1

mauritsvanrees added a commit that referenced this issue Jun 15, 2024
See #99 (comment).
This is for Plone 6.1 only.
Needs a small fix in plone.app.upgrade for good measure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants