-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't error out on 'Africa/Abidjan' timezone [gyst] #394
Conversation
@gyst thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
Please note that running tests locally gives two errors I also get when running tests against |
@jenkins-plone-org please run jobs |
@gyst I tried this in a Plone site with the site timezone set to Africa/Abidjan. This change avoids the OverflowError, but I got a different error instead.
|
This fix is for an event with the timezone set to Africa/Abidjan. I did not think about setting the site timezone. This looks like potentially a separate (though similar) bug? |
@jenkins-plone-org please run jobs |
I think @davisagli found a different bug. I am fine to merge this one if all is green here and you create a new issue with above findings. |
Fixes #393 by not using our own
null
datetime, which was equal but not identical todatetime.min
.The test provided throws an OverflowError without the patch provided.