Skip to content

Commit

Permalink
Merge pull request #102 from plone/thet-fixes
Browse files Browse the repository at this point in the history
folder contents properties fix + rename images scale
  • Loading branch information
thet authored Aug 29, 2016
2 parents b87e937 + 4656257 commit f170063
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 8 deletions.
7 changes: 6 additions & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,15 @@ Breaking changes:

New features:

- *add item here*
- Folder contents rename dialog: In the rename dialog, show image thumbnails in ``thumb`` scale instead of ``icon``.
Plones standard ``icon`` scale is way to small to be useful for images.
[thet]

Bug fixes:

- Folder contents properties dialog: Fix form request variables for ``effectiveDate`` and ``expirationDate`` dates.
[thet]

- Fix a json "circular reference detected" error which happened when the json dumper got unparsable data types.
[pcdummy]

Expand Down
6 changes: 3 additions & 3 deletions plone/app/content/browser/contents/templates/properties.pt
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<div i18n:domain="plone">
<div class="form-group">
<label i18n:translate="publiciation_date">Publication Date</label>
<input class="form-control pat-pickadate" name="effective" />
<input class="form-control pat-pickadate" name="effectiveDate" />
</div>
<div class="form-group">
<label i18n:translate="expiration_date">Expiration Date</label>
<input class="form-control pat-pickadate" name="expiration" />
<input class="form-control pat-pickadate" name="expirationDate" />
</div>
<div class="form-group">
<label i18n:translate="copyright">Copyright</label>
Expand Down Expand Up @@ -38,4 +38,4 @@
<span i18n:translate="no">No</span>
</label>
</div>
</div>
</div>
9 changes: 5 additions & 4 deletions plone/app/content/browser/contents/templates/rename.pt
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
<div class="itemstoremove" i18n:domain="plone">
<% _.each(items, function(item, index) { %>
<div class="item">
<% if(item.getIcon ){ %><img class="image-icon" src="<%= item.getURL %>/@@images/image/icon"><% } %>
<div class="form-group">
<div class="form-group">
<input name="UID_<%= index %>" type="hidden" value="<%- item.UID %>" />
<label i18n:translate="label_title">Title</label>
<input class="form-control" name="newtitle_<%= index %>" value="<%= item.Title %>" />
<label i18n:translate="label_short_name">Short name</label>
<input class="form-control" name="newid_<%= index %>" value="<%= item.id %>" />
</div>
<% if(item.getIcon ){ %><img class="image-thumb" src="<%= item.getURL %>/@@images/image/thumb"><% } %>
</div>
<% }) %>
</div>
</div>

0 comments on commit f170063

Please sign in to comment.