-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to a 4K x 4K browser window in Robot tests #2865
Conversation
@Rotonen thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:
With this simple comment all the jobs will be started automatically. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay, but this does not really change anything about 4Kx4K, right? That is handled in your merged p.a.robotframework PR. Or does changing Plone Test Setup
to Plone test setup
change anything? Does the capitalisation matter?
I've done the work with a script. At least I can still happily clean up and drop the meaningless capitalization changes, if so desired. I am not in any particular hurry with this process. |
If it is more consistent after this change, it is good. |
08aa2c3
to
82226b3
Compare
Part of the stability is also future proofing stability over time. If we have the exact functionally same setups everywhere, local copy pasting will lead also to a new test, which works, and keeps working. @jenkins-plone-org please run jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mauritsvanrees I've also slipped through a botched changelog entry through here. Sorry. |
Okido, fixed on master in d1fcfd0. No problem. |
I'm in the process of trying to unify Robot test setups and teardowns. This is a part of that effort.
Also re-enabled two previously disabled Robot tests.
In tandem with plone/plone.app.robotframework#110
Closes #2864