Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to a 4K x 4K browser window in Robot tests #2865

Merged
merged 1 commit into from
May 21, 2019

Conversation

Rotonen
Copy link
Contributor

@Rotonen Rotonen commented May 14, 2019

I'm in the process of trying to unify Robot test setups and teardowns. This is a part of that effort.

Also re-enabled two previously disabled Robot tests.

In tandem with plone/plone.app.robotframework#110
Closes #2864

@mister-roboto
Copy link

@Rotonen thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@Rotonen Rotonen requested review from tisto and datakurre May 14, 2019 10:56
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, but this does not really change anything about 4Kx4K, right? That is handled in your merged p.a.robotframework PR. Or does changing Plone Test Setup to Plone test setup change anything? Does the capitalisation matter?

@Rotonen
Copy link
Contributor Author

Rotonen commented May 20, 2019

I've done the work with a script.

At least Products/CMFPlone/tests/robot/test_controlpanel_actions.robot has actually changed in regards to how it is now set up.

I can still happily clean up and drop the meaningless capitalization changes, if so desired. I am not in any particular hurry with this process.

@mauritsvanrees
Copy link
Member

If it is more consistent after this change, it is good.

@Rotonen Rotonen force-pushed the roto-window-resize-huge branch from 08aa2c3 to 82226b3 Compare May 21, 2019 07:10
@Rotonen
Copy link
Contributor Author

Rotonen commented May 21, 2019

Part of the stability is also future proofing stability over time. If we have the exact functionally same setups everywhere, local copy pasting will lead also to a new test, which works, and keeps working.

@jenkins-plone-org please run jobs

@Rotonen Rotonen requested a review from mauritsvanrees May 21, 2019 08:29
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauritsvanrees mauritsvanrees merged commit 894f6dc into master May 21, 2019
@mauritsvanrees mauritsvanrees deleted the roto-window-resize-huge branch May 21, 2019 08:43
@Rotonen
Copy link
Contributor Author

Rotonen commented May 21, 2019

@mauritsvanrees I've also slipped through a botched changelog entry through here. Sorry.

@mauritsvanrees
Copy link
Member

Okido, fixed on master in d1fcfd0. No problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Robot tests to use new shared test setups
3 participants