-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
\iffieldxref{labeltitle} when the main entry has no title. #588
Comments
This is an interesting one. As far as I can tell it comes from the fact that Essentially |
This is correct - I suspect the solution is fairly simple - use the |
OK, here is a possible fix Instead of only deleting the (one relevant) field with
becomes
|
I will try to do test this week-end. Please send me an email monday if I didn't do. |
Hi, I have tried the pull requets #590 with the previous MWE. I get
(/Users/maieul/Library/texmf/tex/latex/biblatex/biblatex.cfg))
! Missing number, treated as zero.
|
(I get it before the \addbibresource / \bibliography command) |
Ah yes. If you just download the files from dev you get errors, because the files have no version information in |
Ok. I tried with this MWE + a real case use. All is fine (but I have only one case if `\iffieldxref` in my styles.
|
Brilliant. Thanks for following up on this. Theoretically, there should be no problem with the patch. And a few tests I ran brought up no problems, either. I think we can merge. |
For reledmac, I have found a way to make test to be sure there is no breaking change. I have a script which
It is quite long to execute, but I am sur it's working. |
I have merged and updated 3.8 DEV. I think we should release very shortly. I already have a test suite like that which compares PDFs like that. |
nice ! |
PLK also has some test suite in place. The danger is always that your test cases don't cover everything. As far as I can see |
We don't test anywhere near everything in detail - @josephwright was looking into a real test suite using expl3 and I have a basic framework in place for this but there were structural issues with testing package and biber last time I looked. |
Hi, suppose the following things:
a @book entry without title
a @inBook entry with title, with crossref to the @book entry.
`\iffieldxref{title} return false, as expected.
`\iffieldxref{labeltitle} return true, which is not the expected result.
Cf the MWE
The text was updated successfully, but these errors were encountered: