Update measure memory test #1363
Conversation
WalkthroughThe recent updates enhance memory configurations, introduce new parameters, and improve code clarity across the project. Memory measurement expectations have been increased for various resource setups to better align with anticipated usage. Additionally, a new cache expiration parameter for token verification was added to the API documentation, and variable naming in the JWT validator was refined for better readability, contributing to overall system robustness. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/measureMemory.yml (2 hunks)
- device-provisioning-service/README.md (1 hunks)
- pkg/security/jwt/validator/validator.go (1 hunks)
Files skipped from review due to trivial changes (1)
- pkg/security/jwt/validator/validator.go
Additional comments not posted (6)
.github/workflows/measureMemory.yml (5)
73-73: Increased memory threshold for low configurations.The
expectedRssInMbvalue has been increased from 50 to 100. This change aligns with the PR's objective to make the memory test more lenient.Also applies to: 79-79, 85-85, 91-91, 97-97, 103-103, 109-109, 115-115
124-124: Increased memory threshold for 1000 device configurations.The
expectedRssInMbvalue has been increased from 145 to 250. This adjustment is consistent with the goal of accommodating higher memory usage.Also applies to: 130-130, 136-136, 142-142, 148-148, 154-154, 160-160, 166-166
173-173: Increased memory threshold for 2500 device configurations.The
expectedRssInMbvalue has been increased from 210 to 350. This change is in line with the updated memory expectations.Also applies to: 179-179, 185-185, 191-191, 197-197, 203-203, 209-209, 215-215
222-222: Increased memory threshold for 5000 device configurations.The
expectedRssInMbvalue has been increased from 320 to 500. This is part of the broader effort to adjust memory expectations.Also applies to: 228-228, 234-234, 240-240, 246-246, 252-252, 258-258, 264-264
271-271: Increased memory threshold for 10000 device configurations.The
expectedRssInMbvalue has been increased from 530 to 800. This substantial increase reflects the need to accommodate higher memory usage.Also applies to: 277-277, 283-283, 289-289, 295-295, 301-301, 307-307, 313-313
device-provisioning-service/README.md (1)
79-79: New configuration parameter for token cache expiration.The
apis.http.authorization.tokenTrustVerification.cacheExpirationparameter has been added, allowing control over token cache duration. This addition enhances security by managing token validity more effectively.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Makefile (5 hunks)
Additional comments not posted (3)
Makefile (3)
42-46: Improved configuration flexibility with conditional verbosity.The conditional assignment of
MONGODB_ARGSbased onTEST_MONGODB_VERBOSEenhances flexibility, allowing verbosity to be toggled easily.
211-212: Consistent verbosity configuration for MongoDB instances.The use of
MONGODB_ARGSin theRUN-DOCKER-MONGOfunction ensures consistent application of verbosity settings across MongoDB instances.
223-225: Aligned MongoDB targets with dynamic configuration approach.The updates to
mongoandmongo-no-replicastargets align with the dynamic configuration approach, utilizingMONGODB_ARGSfor verbosity control.Also applies to: 260-260
Set high threshold for memory usage, we want the test succeed and only fail if the memory usage increases dramatically.
Danielius1922
force-pushed
the
adam/feature/fix-documentation
branch
from
24ff2f8 to
16ab5fa
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/measureMemory.yml (2 hunks)
- device-provisioning-service/README.md (1 hunks)
- pkg/security/jwt/validator/validator.go (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- device-provisioning-service/README.md
- pkg/security/jwt/validator/validator.go
Additional comments not posted (5)
.github/workflows/measureMemory.yml (5)
73-73: Approved: Increased memory threshold for 1 device, 1 resource, 16KB size.The increase in
expectedRssInMbfrom 50 to 100 aligns with the goal of reducing false negatives in memory tests.
79-79: Approved: Increased memory threshold for 1 device, 1 resource, 1KB size.The increase in
expectedRssInMbfrom 50 to 100 is in line with the objective to enhance test reliability.
85-85: Approved: Increased memory threshold for 1 device, 125 resources, 16KB size.Raising
expectedRssInMbfrom 50 to 100 helps in achieving a more lenient memory test.
91-91: Approved: Increased memory threshold for 1 device, 125 resources, 1KB size.Increasing
expectedRssInMbfrom 50 to 100 aligns with the PR's aim to improve test reliability.
307-307: Approved: Increased memory threshold for 10000 devices, 500 resources, 4KB size.The increase in
expectedRssInMbfrom 530 to 800 reflects a reassessment of memory requirements, supporting the PR's objective.
|
Set high threshold for memory usage, we want the test succeed and only fail if the memory usage increases dramatically.