-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve whitespace #168
Preserve whitespace #168
Conversation
46be26b
to
dd86042
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a good change! A few items to consider. Only the first is a blocker.
@jalseth all review comments should be addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! shipit 🚢
|
#159
I was a bad noodle and combined some linting/formatting with the change itself, but have added some discussion comments below highlighting the critical pieces of the change itself.