[DO NOT MERGE] Muhammad/arch 64 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First working build of the rn native library that works within the RNTester app. Still needs to figure out how to include and package JSC
Ensure: * RN bundled assets are done for new arch build variants in react.gradle * remove old gradle property to use DepercatedNdk
To avoid issues with kepler. This BREAKS RNTester.
This commit is part of this PR because: 1. These settings are important when the gradle plugin is the one invoking the ndk command. 2. For ReactAndroid, the ndk commnad (ndk-build in this case) is invoked manually. See gradle task: buildReactNdkLib 3. If the gradle plugin is invoking the ndk command, these lines will cause the plugin to invoke the ndkCompile(old) over ndk-build.
This way, kepler can skip building RN from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: NO NOT MERGE
This PR was created from the v0.55.4 tag and not the head of 0.55-stable branch.
Using this solution to building 64bit variants of RN does not require merging this PR. This PR was created to demonstrate the changes needed to start generating 64bit variants.