FIX all settings / restrictions are now queried correctly #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorin-ciceu
approved these changes
Feb 18, 2020
kevinfink96
reviewed
Feb 21, 2020
CTohme
reviewed
Feb 21, 2020
There was a problem hiding this comment.
It was not to easy for me to read the method public function respectsAllLimitations since all the If-Statements first return false, that was not really intuitiv to me, which made it tough.
But too me it does look good.
We can talk about my comments after the daily if you want.
j-konopka
reviewed
Feb 24, 2020
j-konopka
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@plentymarkets/everyone-read
@dorin-ciceu